Redirect old getting started URL #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pragmatic "Programming Elixir" book references `http://elixir-lang.org/getting_started/1.html` which has been moved to `http://elixir-lang.org/getting-started/introduction.html`. This PR adds a `redirect_from` on the `introduction.markdown` page to ensure that readers of that book are able to use the URL in the book without getting a 404.
Member
|
❤️ 💚 💙 💛 💜 |
Contributor
|
I think conroywhitney@c6183c6 should ve reverted. I think it was agreed to keep it like that as there are countless of webpages linking to the old urls. |
Member
|
@eksperimental I have decided to merge it back because this is the third or fourth time someone complains about this URL explicitly. Since it was the entrypoint into the guide, we shuold probably keep it in the long term. |
Contributor
|
Im totally fine with it. What concerns me is that all the other old links were removed. What was the point in doing so? There are many sources still linking to the old urls |
Contributor
|
Just to be clear. The commit that i mention should be reverted is not this one, but the one introduced by the same author that removed all the old url redirects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pragmatic "Programming Elixir" book references
http://elixir-lang.org/getting_started/1.htmlwhich has been moved tohttp://elixir-lang.org/getting-started/introduction.html. This PR adds aredirect_fromon theintroduction.markdownpage to ensure that readers of that book are able to use the URL in the book without getting a 404.